Skip to content

chore: Add unit test to cover apps health status in an app in any namespace context #23693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crenshaw-dev merged 1 commit into from
Jul 9, 2025
Merged

chore: Add unit test to cover apps health status in an app in any namespace context #23693

crenshaw-dev merged 1 commit into from
Jul 9, 2025

Conversation

@OpenGuidou
Copy link
Contributor

@OpenGuidou OpenGuidou commented Jul 8, 2025 •
edited
Loading

Adding unit test to cover case fixed in #22944.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@OpenGuidou OpenGuidou requested a review from a team as a code owner July 8, 2025 15:37
@bunnyshell
Copy link

bunnyshell bot commented Jul 8, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@OpenGuidou
chore: Add unit test to cover apps health status in an app in any nam…
6286a3b 
…espace context

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
@codecov
Copy link

codecov bot commented Jul 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.21%. Comparing base (09b5cbd) to head (6286a3b).
⚠️ Report is 824 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #23693      +/-   ##
==========================================
- Coverage   60.22%   60.21%   -0.02%     
==========================================
  Files         346      346              
  Lines       59197    59202       +5     
==========================================
- Hits        35653    35648       -5     
- Misses      20686    20689       +3     
- Partials     2858     2865       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aali309
aali309 approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

crenshaw-dev
crenshaw-dev approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crenshaw-dev crenshaw-dev merged commit 3f44b85 into argoproj:master Jul 9, 2025
28 checks passed
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jul 9, 2025
@OpenGuidou @dsuhinin
chore: Add unit test to cover apps health status in an app in any nam…
56f4192 
…espace context (argoproj#23693)

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ManishTechie pushed a commit to ManishTechie/argo-cd that referenced this pull request Jul 9, 2025
@OpenGuidou @ManishTechie
chore: Add unit test to cover apps health status in an app in any nam…
66a88ee 
…espace context (argoproj#23693)

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: Manish Kumar <mnskumar07@gmail.com>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
@OpenGuidou @enneitex
chore: Add unit test to cover apps health status in an app in any nam…
8fd3838 
…espace context (argoproj#23693)

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Mangaal pushed a commit to Mangaal/argo-cd that referenced this pull request Sep 10, 2025
@OpenGuidou @Mangaal
chore: Add unit test to cover apps health status in an app in any nam…
eebe884 
…espace context (argoproj#23693)

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
sivasath16 pushed a commit to sivasath16/argo-cd that referenced this pull request Sep 17, 2025
@OpenGuidou
chore: Add unit test to cover apps health status in an app in any nam…
4b5707d 
…espace context (argoproj#23693)

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
sivasath16 pushed a commit to sivasath16/argo-cd that referenced this pull request Sep 17, 2025
@OpenGuidou
chore: Add unit test to cover apps health status in an app in any nam…
7729b91 
…espace context (argoproj#23693)

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

@nitishfy nitishfy nitishfy approved these changes

+1 more reviewer

@aali309 aali309 aali309 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@OpenGuidou @crenshaw-dev @aali309 @nitishfy